Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More raw rpc request testing #6534

Closed
mattsse opened this issue Feb 10, 2024 · 2 comments
Closed

More raw rpc request testing #6534

mattsse opened this issue Feb 10, 2024 · 2 comments
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 10, 2024

Describe the feature

In order to prevent regressions with changes of rpc types we need a few more tests.

Ideally here

https://github.com/paradigmxyz/reth/blob/3c3c7b36adeb0a0491518854a2b13f9f85fc0aff/crates/rpc/rpc-builder/tests/it/http.rs

The tests should not make of the API, but instead send raw json requests (string)

The requests for call related endpoint should include unknown fields, like gasLimit instead of gas this should not cause an error

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 10, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-test A change that impacts how or what we test and removed S-needs-triage This issue needs to be labelled labels Feb 10, 2024
This was referenced Feb 10, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Mar 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattsse