Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not suggest to "Fix beacon client" after CL inactivity #7355

Closed
Rjected opened this issue Mar 27, 2024 · 1 comment · Fixed by #8356
Closed

Do not suggest to "Fix beacon client" after CL inactivity #7355

Rjected opened this issue Mar 27, 2024 · 1 comment · Fixed by #8356
Labels
A-consensus Related to the consensus engine A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@Rjected
Copy link
Member

Rjected commented Mar 27, 2024

Inspired by this issue: #7353

The "Fix your beacon client" suggestion is both inaccurate and not useful, as reth may have been the one to return an error. While this log has been useful in response to users who don't know they need a CL, we should provide accurate information, especially if reth returned an invalid block error. We could also point users to the debug log directory to send to us in a bug report.

We cannot distinguish between "true" invalid blocks and blocks we mark as invalid due to an error in reth until we have hindsight w.r.t. a specific bug, so we should be careful in our wording
@Rjected Rjected added C-bug An unexpected or incorrect behavior A-consensus Related to the consensus engine A-observability Related to tracing, metrics, logs and other observability tools labels Mar 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Apr 18, 2024
@Rjected Rjected added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Apr 18, 2024
@Rjected Rjected mentioned this issue May 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-consensus Related to the consensus engine A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improve HaveNotReceivedUpdatesForAWhile warning paradigmxyz/reth
1 participant
@Rjected