Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert OptimismBlockExecution error variant into a general purpose error variant #8088

Closed
mattsse opened this issue May 4, 2024 · 0 comments · Fixed by #8100
Closed

Convert OptimismBlockExecution error variant into a general purpose error variant #8088

mattsse opened this issue May 4, 2024 · 0 comments · Fixed by #8100
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 4, 2024

Describe the feature

replace

/// Optimism Block Executor Errors
#[cfg(feature = "optimism")]
#[error(transparent)]
OptimismBlockExecution(#[from] OptimismBlockExecutionError),

with something like:

/// Any other payload building errors.
#[error(transparent)]
Other(Box<dyn std::error::Error + Send + Sync>),

it should be fine to remove incompatible derives here, Clone,PartialEq,Eq

#[derive(Error, Debug, Clone, PartialEq, Eq)]

and move Op errors to optimism/evm crate

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels May 4, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-execution Related to the Execution and EVM and removed S-needs-triage This issue needs to be labelled labels May 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant