Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't restrict database error variant on executor #8089

Closed
mattsse opened this issue May 4, 2024 · 3 comments
Closed

Don't restrict database error variant on executor #8089

mattsse opened this issue May 4, 2024 · 3 comments
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 4, 2024

Describe the feature

This should not require ProviderError and should just require Error or Into<BlockExecutionError>

type Executor<DB: Database<Error = ProviderError>>: for<'a> Executor<

blocked by #8088

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels May 4, 2024
@mattsse mattsse added A-execution Related to the Execution and EVM and removed S-needs-triage This issue needs to be labelled labels May 4, 2024
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label May 26, 2024
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels May 26, 2024
@sergerad
Copy link
Contributor

@mattsse I have looked into this one out of interest. Wanted to ask if you thought the diffs in the PR are on the right track or not.

I assume I can get around the current compiler error by implementing the appropriate from() or into(). But it feels like that could be going down the wrong track and likely to hit many more issues after that.

required for `revm_primitives::EVMError<std::boxed::Box<dyn std::error::Error>>` to implement `std::convert::Into<std::boxed::Box<revm_primitives::EVMError<reth_evm::execute::ProviderError>>>`

Any insight / direction would be appreciated, thanks 🙏

@mattsse
Copy link
Collaborator Author

mattsse commented May 31, 2024

ah sorry I forgot to link the relevant issue #8152

this problem will go away with an upcoming stable rust feature, on nightly this already works

@mattsse mattsse closed this as completed Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

No branches or pull requests

2 participants