Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate eth request metrics into grafana dashboard #8334

Closed
Rjected opened this issue May 21, 2024 · 6 comments · Fixed by #9026
Closed

Integrate eth request metrics into grafana dashboard #8334

Rjected opened this issue May 21, 2024 · 6 comments · Fixed by #9026
Assignees
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@Rjected
Copy link
Member

Rjected commented May 21, 2024

Describe the feature

We have the following metrics for the different eth request types:

/// Metrics for the EthRequestHandler
#[derive(Metrics)]
#[metrics(scope = "network")]
pub struct EthRequestHandlerMetrics {
/// Number of GetBlockHeaders requests received
pub(crate) eth_headers_requests_received_total: Counter,
/// Number of GetReceipts requests received
pub(crate) eth_receipts_requests_received_total: Counter,
/// Number of GetBlockBodies requests received
pub(crate) eth_bodies_requests_received_total: Counter,
/// Number of GetNodeData requests received
pub(crate) eth_node_data_requests_received_total: Counter,
}

These should be added to the grafana dashboard, so we can observe in real time how many of each type of request we receive.

Additional context

No response

@Rjected Rjected added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-needs-triage This issue needs to be labelled A-observability Related to tracing, metrics, logs and other observability tools labels May 21, 2024
@Rjected Rjected removed the S-needs-triage This issue needs to be labelled label May 21, 2024
@hopinheimer
Copy link

hopinheimer commented May 21, 2024

I'd like to work on this @Rjected

@Rjected
Copy link
Member Author

Rjected commented May 21, 2024

I'd like to work on this @Rjected

sure! assigned

@Rjected
Copy link
Member Author

Rjected commented Jun 6, 2024

I'd like to work on this @Rjected

@hopinheimer any updates / need any help?

@hopinheimer
Copy link

apologies @Rjected for a really delayed response. I'm not available for sometime and I think this issue is time sensitive so, I'm unassigning myself -- I really regret for the inconvenience caused

@hopinheimer hopinheimer removed their assignment Jun 17, 2024
@d3or
Copy link
Contributor

d3or commented Jun 21, 2024

Hey! Can I take this on?

@Rjected
Copy link
Member Author

Rjected commented Jun 21, 2024

@d3or sure, just assigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants