Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable discv5 for op in reth-node-optimism crate #8499

Closed
Tracked by #7649
emhane opened this issue May 29, 2024 · 3 comments · Fixed by #8690
Closed
Tracked by #7649

Enable discv5 for op in reth-node-optimism crate #8499

emhane opened this issue May 29, 2024 · 3 comments · Fixed by #8690
Assignees
Labels
A-op-reth Related to Optimism and op-reth C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented May 29, 2024

Describe the feature

Move network specific logic that enables discv5 for an op network into reth-node-optimism crate.

if chain_spec.is_optimism() && !self.discovery.disable_discovery {
network_config_builder =
network_config_builder.discovery_v5(reth_discv5::Config::builder(rlpx_socket));
}

.disable_discv4_discovery_if(self.chain.chain.is_optimism())

Additional context

No response

@emhane emhane added C-debt A clean up/refactor of existing code A-op-reth Related to Optimism and op-reth labels May 29, 2024
@emhane emhane changed the title Enable discv5 for op in node-optimism crate Enable discv5 for op in reth-node-optimism crate May 29, 2024
@mattsse mattsse added the D-good-first-issue Nice and easy! A great choice to get started label Jun 6, 2024
@qiweiii
Copy link
Contributor

qiweiii commented Jun 7, 2024

can i take this?

@mattsse
Copy link
Collaborator

mattsse commented Jun 7, 2024

sure

we can configure this in the OP network builder:

let mut network_config = ctx.network_config()?;

@qiweiii
Copy link
Contributor

qiweiii commented Jun 8, 2024

@mattsse @emhane please check if the pr changes are the expected solution

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants