Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build features only includes reth-node-core features #8623

Closed
Tracked by #7576
DaniPopes opened this issue Jun 5, 2024 · 3 comments
Closed
Tracked by #7576

Build features only includes reth-node-core features #8623

DaniPopes opened this issue Jun 5, 2024 · 3 comments
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@DaniPopes
Copy link
Member

Describe the feature

The generated VERGEN_CARGO_FEATURES uses the features passed only to reth-node-core, so the features displayed in grafana / --version output does not contain all the features passed to cargo build --features ...

This can be fixed by either passing through relevant features to the crate, even if they won't do anything, or moving the build script to the reth crate. cc @mattsse

Additional context

No response

@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Jun 5, 2024
@DaniPopes DaniPopes changed the title Build features only includes features in reth-node-core Build features only includes reth-node-core features Jun 5, 2024
@mattsse
Copy link
Collaborator

mattsse commented Jun 6, 2024

yeah the only reason this is still in there is because the commands use the version constant for things like client identifier/extradata

we perhaps there's a way to use a global static instead that we then set from reth binary?

ref #7576

Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jun 27, 2024
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jun 27, 2024
@DaniPopes
Copy link
Member Author

Fixed by #9866

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

No branches or pull requests

2 participants