Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify OptimismGenesis Info extraction #8952

Closed
mattsse opened this issue Jun 19, 2024 · 1 comment · Fixed by #9031
Closed

Simplify OptimismGenesis Info extraction #8952

mattsse opened this issue Jun 19, 2024 · 1 comment · Fixed by #9031
Assignees
@Vid201
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 19, 2024

Describe the feature

with alloy 0.1.2 we can simplify this:

reth/crates/chainspec/src/spec.rs

Line 1398 in 590356b

fn extract_from(genesis: &Genesis) -> Self {

and can use the Otherfields API to extract all fields:

https://alloy-rs.github.io/alloy/alloy/rpc/types/serde_helpers/struct.OtherFields.html#method.deserialize_as

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 19, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Jun 19, 2024
@Vid201
Copy link
Contributor

Vid201 commented Jun 21, 2024

I can take this

@Vid201 Vid201 mentioned this issue Jun 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vid201 Vid201

Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: simplify OptimismGenesisInfo extraction Vid201/reth
2 participants
@mattsse @Vid201