Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for blob nonce gap errors #9018

Closed
mattsse opened this issue Jun 21, 2024 · 2 comments · Fixed by #9106
Closed

Add metric for blob nonce gap errors #9018

mattsse opened this issue Jun 21, 2024 · 2 comments · Fixed by #9106
Assignees
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 21, 2024

Describe the feature

nonce gaps for blob txs are disallowed:

let Some(ancestor_tx) = self.txs.get(&ancestor) else {
// ancestor tx is missing, so we can't insert the new blob
return Err(InsertErr::BlobTxHasNonceGap { transaction: Arc::new(new_blob_tx) })
};
if ancestor_tx.state.has_nonce_gap() {
// the ancestor transaction already has a nonce gap, so we can't insert the new
// blob
return Err(InsertErr::BlobTxHasNonceGap { transaction: Arc::new(new_blob_tx) })
}

we should add a counter for this in a metric

pub struct AllTransactionsMetrics {

TODO

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request A-tx-pool Related to the transaction mempool A-observability Related to tracing, metrics, logs and other observability tools labels Jun 21, 2024
@mattsse mattsse added the D-good-first-issue Nice and easy! A great choice to get started label Jun 25, 2024
@leruaa
Copy link
Contributor

leruaa commented Jun 25, 2024

I can take this on.

@Rjected
Copy link
Member

Rjected commented Jun 25, 2024

@leruaa assigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants