Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move node-core/engine to standalone crate #9099

Closed
mattsse opened this issue Jun 25, 2024 · 0 comments · Fixed by #9120
Closed

move node-core/engine to standalone crate #9099

mattsse opened this issue Jun 25, 2024 · 0 comments · Fixed by #9120
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 25, 2024

Describe the feature

this is responsible for a lot of bloat

reth/crates/node-core/src/engine/mod.rs

Line 1 in 270df3e

//! Collection of various stream utilities for consensus engine.

and should be moved to crates/engine/util

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 25, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Jun 25, 2024
@tcoratger tcoratger mentioned this issue Jun 26, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move node-core/engine to standalone crate tcoratger/reth
1 participant
@mattsse