Move HackReceiptFileCodec into reth-optimism-cli

[emhane]

Describe the feature

Move HackReceiptFileCodec into reth-optimism-cli.

reth/crates/net/downloaders/src/file_codec_ovm_receipt.rs

Lines 12 to 47 in d599393

	/// Codec for reading raw receipts from a file.
	///
	/// If using with [`FramedRead`](tokio_util::codec::FramedRead), the user should make sure the
	/// framed reader has capacity for the entire receipts file. Otherwise, the decoder will return
	/// [`InputTooShort`](alloy_rlp::Error::InputTooShort), because RLP receipts can only be
	/// decoded if the internal buffer is large enough to contain the entire receipt.
	///
	/// Without ensuring the framed reader has capacity for the entire file, a receipt is likely to
	/// fall across two read buffers, the decoder will not be able to decode the receipt, which will
	/// cause it to fail.
	///
	/// It's recommended to use [`with_capacity`](tokio_util::codec::FramedRead::with_capacity) to set
	/// the capacity of the framed reader to the size of the file.
	#[derive(Debug, Default)]
	pub struct HackReceiptFileCodec;
	impl Decoder for HackReceiptFileCodec {
	type Item = Option<ReceiptWithBlockNumber>;
	type Error = FileClientError;
	fn decode(&mut self, src: &mut BytesMut) -> Result<Option<Self::Item>, Self::Error> {
	if src.is_empty() {
	return Ok(None)
	}
	let buf_slice = &mut src.as_ref();
	let receipt = HackReceiptContainer::decode(buf_slice)
	.map_err(|err| Self::Error::Rlp(err, src.to_vec()))?
	.0;
	src.advance(src.len() - buf_slice.len());
	Ok(Some(
	receipt.map(|receipt| receipt.try_into().map_err(FileClientError::from)).transpose()?,
	))
	}
	}

Requires implementing a mock receipt file codec to replace HackReceiptFileCodec in ReceiptFileClient tests.

reth/crates/net/downloaders/src/receipt_file_client.rs

Lines 221 to 339 in d599393

	#[cfg(test)]
	mod test {
	use reth_primitives::hex;
	use reth_tracing::init_test_tracing;
	use crate::file_codec_ovm_receipt::{
	test::{
	receipt_block_1 as op_mainnet_receipt_block_1,
	receipt_block_2 as op_mainnet_receipt_block_2,
	receipt_block_3 as op_mainnet_receipt_block_3,
	HACK_RECEIPT_ENCODED_BLOCK_1 as HACK_RECEIPT_ENCODED_BLOCK_1_OP_MAINNET,
	HACK_RECEIPT_ENCODED_BLOCK_2 as HACK_RECEIPT_ENCODED_BLOCK_2_OP_MAINNET,
	HACK_RECEIPT_ENCODED_BLOCK_3 as HACK_RECEIPT_ENCODED_BLOCK_3_OP_MAINNET,
	},
	HackReceiptFileCodec,
	};
	use super::*;
	/// No receipts for genesis block
	const HACK_RECEIPT_BLOCK_NO_TRANSACTIONS: &[u8] = &hex!("c0");
	#[tokio::test]
	async fn receipt_file_client_ovm_codec() {
	init_test_tracing();
	// genesis block has no hack receipts
	let mut encoded_receipts = HACK_RECEIPT_BLOCK_NO_TRANSACTIONS.to_vec();
	// one receipt each for block 1 and 2
	encoded_receipts.extend_from_slice(HACK_RECEIPT_ENCODED_BLOCK_1_OP_MAINNET);
	encoded_receipts.extend_from_slice(HACK_RECEIPT_ENCODED_BLOCK_2_OP_MAINNET);
	// no receipt for block 4
	encoded_receipts.extend_from_slice(HACK_RECEIPT_BLOCK_NO_TRANSACTIONS);
	let encoded_byte_len = encoded_receipts.len() as u64;
	let reader = &mut &encoded_receipts[..];
	let (
	ReceiptFileClient { receipts, first_block, total_receipts, _marker },
	_remaining_bytes,
	) = ReceiptFileClient::<HackReceiptFileCodec>::from_reader(reader, encoded_byte_len)
	.await
	.unwrap();
	// 2 non-empty receipt objects
	assert_eq!(2, total_receipts);
	assert_eq!(0, first_block);
	assert!(receipts[0].is_empty());
	assert_eq!(op_mainnet_receipt_block_1().receipt, receipts[1][0].clone().unwrap());
	assert_eq!(op_mainnet_receipt_block_2().receipt, receipts[2][0].clone().unwrap());
	assert!(receipts[3].is_empty());
	}
	#[tokio::test]
	async fn no_receipts_middle_block() {
	init_test_tracing();
	// genesis block has no hack receipts
	let mut encoded_receipts = HACK_RECEIPT_BLOCK_NO_TRANSACTIONS.to_vec();
	// one receipt each for block 1
	encoded_receipts.extend_from_slice(HACK_RECEIPT_ENCODED_BLOCK_1_OP_MAINNET);
	// no receipt for block 2
	encoded_receipts.extend_from_slice(HACK_RECEIPT_BLOCK_NO_TRANSACTIONS);
	// one receipt for block 3
	encoded_receipts.extend_from_slice(HACK_RECEIPT_ENCODED_BLOCK_3_OP_MAINNET);
	let encoded_byte_len = encoded_receipts.len() as u64;
	let reader = &mut &encoded_receipts[..];
	let (
	ReceiptFileClient { receipts, first_block, total_receipts, _marker },
	_remaining_bytes,
	) = ReceiptFileClient::<HackReceiptFileCodec>::from_reader(reader, encoded_byte_len)
	.await
	.unwrap();
	// 2 non-empty receipt objects
	assert_eq!(2, total_receipts);
	assert_eq!(0, first_block);
	assert!(receipts[0].is_empty());
	assert_eq!(op_mainnet_receipt_block_1().receipt, receipts[1][0].clone().unwrap());
	assert!(receipts[2].is_empty());
	assert_eq!(op_mainnet_receipt_block_3().receipt, receipts[3][0].clone().unwrap());
	}
	#[tokio::test]
	async fn two_receipts_same_block() {
	init_test_tracing();
	// genesis block has no hack receipts
	let mut encoded_receipts = HACK_RECEIPT_BLOCK_NO_TRANSACTIONS.to_vec();
	// one receipt each for block 1
	encoded_receipts.extend_from_slice(HACK_RECEIPT_ENCODED_BLOCK_1_OP_MAINNET);
	// two receipts for block 2
	encoded_receipts.extend_from_slice(HACK_RECEIPT_ENCODED_BLOCK_2_OP_MAINNET);
	encoded_receipts.extend_from_slice(HACK_RECEIPT_ENCODED_BLOCK_2_OP_MAINNET);
	// one receipt for block 3
	encoded_receipts.extend_from_slice(HACK_RECEIPT_ENCODED_BLOCK_3_OP_MAINNET);
	let encoded_byte_len = encoded_receipts.len() as u64;
	let reader = &mut &encoded_receipts[..];
	let (
	ReceiptFileClient { receipts, first_block, total_receipts, _marker },
	_remaining_bytes,
	) = ReceiptFileClient::<HackReceiptFileCodec>::from_reader(reader, encoded_byte_len)
	.await
	.unwrap();
	// 4 non-empty receipt objects
	assert_eq!(4, total_receipts);
	assert_eq!(0, first_block);
	assert!(receipts[0].is_empty());
	assert_eq!(op_mainnet_receipt_block_1().receipt, receipts[1][0].clone().unwrap());
	assert_eq!(op_mainnet_receipt_block_2().receipt, receipts[2][0].clone().unwrap());
	assert_eq!(op_mainnet_receipt_block_2().receipt, receipts[2][1].clone().unwrap());
	assert_eq!(op_mainnet_receipt_block_3().receipt, receipts[3][0].clone().unwrap());
	}
	}

Additional context

No response

[nkysg]

Can I take this?