Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error running make pr #9424

Closed
1 task done
smatthewenglish opened this issue Jul 10, 2024 · 2 comments · Fixed by #9427
Closed
1 task done

error running make pr #9424

smatthewenglish opened this issue Jul 10, 2024 · 2 comments · Fixed by #9427
Assignees
@smatthewenglish
Labels
C-bug An unexpected or incorrect behavior C-debt A clean up/refactor of existing code

Comments

@smatthewenglish
Copy link
Contributor

Describe the bug

when i run make pr locally, on a clean version of main, i'm getting this error

Screenshot 2024-07-10 at 12 51 55 PM

Steps to reproduce

run make pr

Node logs

No response

Platform(s)

Mac (Apple Silicon)

What version/commit are you on?

reth Version: 0.2.0-beta.6-dev
Commit SHA: 4f81f3a
Build Timestamp: 2024-04-24T17:36:05.491079000Z
Build Features: jemalloc
Build Profile: release

What database version are you on?

Current database version: 2
Local database version: 2

Which chain / network are you on?

dev

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@smatthewenglish smatthewenglish added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Jul 10, 2024
@mattsse
Copy link
Collaborator

mattsse commented Jul 10, 2024

new clippy lint -.-
do you want to submit the suggested fix?

@mattsse mattsse added C-debt A clean up/refactor of existing code and removed S-needs-triage This issue needs to be labelled labels Jul 10, 2024
@smatthewenglish
Copy link
Contributor Author

yeah sure!

@smatthewenglish smatthewenglish mentioned this issue Jul 10, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smatthewenglish smatthewenglish

Labels
C-bug An unexpected or incorrect behavior C-debt A clean up/refactor of existing code
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: resolve new clippy error w/ suggested fix smatthewenglish/reth
2 participants
@smatthewenglish @mattsse