Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new BlockchainProvider type #9607

Closed
Tracked by #8742
mattsse opened this issue Jul 18, 2024 · 0 comments · Fixed by #9656
Closed
Tracked by #8742

Add new BlockchainProvider type #9607

mattsse opened this issue Jul 18, 2024 · 0 comments · Fixed by #9656
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 18, 2024

the current BlockchainProvider type is tied to the blockchaintree implementation.

this will change with the new inmemory state:

// TODO: replace chain_info with CanonicalInMemoryState.
//canonical_in_memory_state: CanonicalInMemoryState,

instead of modifying the existing one, we should roll a new type that will eventually replace BlockchainProvider once we do the transition.

#9606 allows us to do this without much hassle

TODO

first:

  • duplicate
    // TODO: replace chain_info with CanonicalInMemoryState.
    //canonical_in_memory_state: CanonicalInMemoryState,
    maybe we name it BlockchainProvider2 for now
  • integrate InMemoryState, remove dyn tree
  • update trait implementations

followup:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants