Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StateProvider::pending_with_provider trait function #9849

Closed
Tracked by #8742
mattsse opened this issue Jul 27, 2024 · 0 comments · Fixed by #9850
Closed
Tracked by #8742

Remove StateProvider::pending_with_provider trait function #9849

mattsse opened this issue Jul 27, 2024 · 0 comments · Fixed by #9850
Assignees
Labels
C-debt A clean up/refactor of existing code

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 27, 2024

this function is legacy blockchaintree specific behaviour and should be removed from the trait because only called internally

/// Return a [StateProvider] that contains bundle state data provider.
/// Used to inspect or execute transaction on the pending state.
fn pending_with_provider(
&self,
bundle_state_data: Box<dyn FullExecutionDataProvider>,
) -> ProviderResult<StateProviderBox>;

@mattsse mattsse added the C-debt A clean up/refactor of existing code label Jul 27, 2024
@mattsse mattsse self-assigned this Jul 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant