Use global secp256k1 context for tests #12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonatan-Chaverri
requested review from
Rjected,
mattsse and
gakonst
as code owners
mattsse
requested changes
Nov 6, 2024
| @@ -20,7 +20,7 @@ alloy-consensus.workspace = true | |||
| alloy-eips.workspace = true | |||
|
|
|||
| rand.workspace = true | |||
| secp256k1 = { workspace = true, features = ["rand"] } | |||
| secp256k1 = { workspace = true, features = ["rand", "global-context"] } | |||
There was a problem hiding this comment.
this actually looks unused because no changes actually use the global context
| @@ -141,7 +141,7 @@ pub fn random_signed_tx<R: Rng>(rng: &mut R) -> TransactionSigned { | |||
|
|
|||
| /// Signs the [Transaction] with a random key pair. | |||
| pub fn sign_tx_with_random_key_pair<R: Rng>(rng: &mut R, tx: Transaction) -> TransactionSigned { | |||
| let secp = Secp256k1::new(); | |||
| let secp = Secp256k1::signing_only(); | |||
There was a problem hiding this comment.
this isn't the global context
mattsse
added
C-debt
Jonatan-Chaverri
force-pushed
the
use_global_secp
branch
from
cd93dee to
0b2fb1d
Compare
|
@mattsse please check again and let me know if this is what you mean by global context |
mattsse
approved these changes
Nov 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12260