Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract insert_state to ProviderCaches #14714

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 26, 2025

prep for #14589

no functional changes, extracts the insert loop into a function of ProviderCaches

Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #14714 will degrade performances by 10.21%

Comparing matt/extract-insert-state-to-provider-cache (ff5c3e4) with main (1809ee5)

Summary

❌ 1 regressions
✅ 76 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
hash builder[init size 10000 | update size 100 | num updates 1] 8.9 ms 9.9 ms -10.21%

@mattsse mattsse added the C-debt A clean up/refactor of existing code label Feb 26, 2025
@mattsse mattsse enabled auto-merge February 26, 2025 08:46
@mattsse mattsse added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 5b19846 Feb 26, 2025
42 of 43 checks passed
@mattsse mattsse deleted the matt/extract-insert-state-to-provider-cache branch February 26, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants