feat(snapshots): refactor snapshot data access #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b9c51e9.
joshieDo
added
C-enhancement
joshieDo
changed the title
mattsse
requested changes
Nov 27, 2023
| /// File descriptor. Needs to be kept alive as long as the mmap handle. | ||
| /// Manages the reading of snapshot data using memory-mapped files. | ||
| /// | ||
| /// Holds file and mmap descriptors of the data and offsets files of a snapshot. |
Co-authored-by: Matthias Seitz <[email protected]>
shekhirin
reviewed
Dec 1, 2023
| @@ -235,39 +235,61 @@ where | |||
|
|
|||
| // SAFETY: File is read-only and its descriptor is kept alive as long as the mmap handle. | |||
| let data_reader = unsafe { memmap2::Mmap::map(&data_file)? }; | |||
| let mut obj: Self = bincode::deserialize_from(data_reader.as_ref())?; | |||
| let max_row_size: [u8; 8] = | |||
| data_reader.as_ref()[0..8].try_into().expect("slice with incorrect length"); | |||
There was a problem hiding this comment.
nit: the error message is not obvious, should it rather be something about missing header?
| self.offsets.iter().max().expect("should exist.").leading_zeros() as usize + | ||
| 7) / | ||
| 8; | ||
| file.write_all(&[bytes_needed as u8])?; |
There was a problem hiding this comment.
are we writing max_row_size here?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reth node)MmapHandlebecomesDataReader)This allows the loading of snapshots to be quite faster (~30μs), while allowing us to hold more in memory (if not loading filters)