Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert OptimismBlockExecution error variant into a general purpose error variant #8100

Merged
merged 3 commits into from
May 6, 2024
Merged

convert OptimismBlockExecution error variant into a general purpose error variant #8100

merged 3 commits into from
May 6, 2024

Conversation

rupam-04
Copy link
Contributor

@rupam-04 rupam-04 commented May 4, 2024 •
edited
Loading

Fixes #8088

I am getting an error in the following line:

reth/crates/ethereum/evm/src/execute.rs

Lines 526 to 529 in 4b78706

assert_eq!(
err,
BlockExecutionError::Validation(BlockValidationError::MissingParentBeaconBlockRoot)
);

Any pointers on how to fix it?

@rupam-04
Copy link
Contributor Author

rupam-04 commented May 5, 2024

@mattsse Any updates on this?

@rupam-04 rupam-04 requested a review from mattsse as a code owner May 6, 2024 12:49
mattsse
mattsse approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

I also moved the OP error type

@mattsse mattsse added the C-debt A clean up/refactor of existing code label May 6, 2024
@mattsse mattsse enabled auto-merge May 6, 2024 13:05
@mattsse mattsse added this pull request to the merge queue May 6, 2024
Merged via the queue into paradigmxyz:main with commit 5e77831 May 6, 2024
29 checks passed
@rupam-04 rupam-04 deleted the issue-8088 branch May 6, 2024 14:29
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@rupam-04 @mattsse @mw2000
convert OptimismBlockExecution error variant into a general pur…
e7835b3 
…pose error variant (paradigmxyz#8100)

Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert OptimismBlockExecution error variant into a general purpose error variant
2 participants
@rupam-04 @mattsse