Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix clippy errors #9845

Merged
merged 7 commits into from
Jul 27, 2024
Merged

chore: fix clippy errors #9845

merged 7 commits into from
Jul 27, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Jul 27, 2024 •
edited
Loading

Fix lint check error.

clippy::or_fun_call, clippy::unnecessary_struct_initialization

@nkysg nkysg requested review from emhane, mattsse and Rjected as code owners July 27, 2024 03:20
@nkysg nkysg changed the title chore: fix clippy unnecessary-struct-initialization chore: fix clippy Jul 27, 2024
@nkysg nkysg changed the title chore: fix clippy chore: fix clippy errors Jul 27, 2024
@nkysg nkysg mentioned this pull request Jul 27, 2024
Closed
mattsse
mattsse requested changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, one style nit

@mattsse mattsse added the C-debt A clean up/refactor of existing code label Jul 27, 2024
mattsse
mattsse approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quickly applied the nit, to get ci passing for other prs

@mattsse mattsse enabled auto-merge July 27, 2024 05:22
@mattsse mattsse added this pull request to the merge queue Jul 27, 2024
Merged via the queue into paradigmxyz:main with commit 7df4245 Jul 27, 2024
32 checks passed
@nkysg nkysg deleted the fix-clippy-unnecessary-struct-initialization branch July 27, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@emhane emhane Awaiting requested review from emhane

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkysg @mattsse