feat: expose extrinsics operations as a library #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tareknaser
requested review from
cmichi,
ascjones,
HCastano and
SkymanOne
as code owners
|
User @tareknaser360, please sign the CLA here. |
ascjones
reviewed
Jun 27, 2023
|
Hey @tareknaser360, some of the tests e.g. for |
This commit introduces a library that exposes extrinsics operations as a reusable component. This makes it easier to integrate and reuse these operations in various projects. Signed-off-by: Tarek <[email protected]>
This commit refines the code to avoid exposing the entire module Signed-off-by: Tarek <[email protected]>
This commit exposes DenominatedBalance and UnitPrefix. This commit also refactors 3 docs examples to initialize BalanceVariant from string because its fields are private Signed-off-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
tareknaser
force-pushed
the
extrinsics-crate
branch
from
428fbfb to
c0a6d00
Compare
I looked into the failing tests in the CI environment and made the following updates:
I also rebased on top of master. |
Signed-off-by: Tarek <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a library that exposes extrinsics operations as a reusable component. This makes it easier to integrate and reuse these operations in various projects.
Fixes #1140
Notes to Reviewers:
runtime_apimodule has been moved to the new crate to avoid cyclic dependencies.CodeHash,Balance, andClienthave been defined in the new crate for the same reason.