Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

DesiredCandidates lower than MinCandidates #2837

Closed
lazam opened this issue Jul 6, 2023 · 2 comments
Closed

DesiredCandidates lower than MinCandidates #2837

lazam opened this issue Jul 6, 2023 · 2 comments

Comments

@lazam
Copy link
Member

lazam commented Jul 6, 2023

We encounter the scenario in Rococo Assethub which was initially set to DesiredCandidates: 1. You can set the DesiredCandidates lower than MinCandidates but the collator can't be removed due to TooFewCandidates. It will be better to have a check and reject the call if the DesiredCandidates <= MinCandidates.

@bkchr
Copy link
Member

bkchr commented Jul 10, 2023

Not sure this makes sense. The MinCandidates are compared against the candidates + invulnerable. So, it is totally fine to say that desired_candidates == 1 and having min candidates of 2 and then having an invulnerable of 1.

@joepetrowski
Copy link
Contributor

Rococo AH is still on v9430, which is before the change from MinCandidates to MinCollators, so this should already be sorted by #2801

https://github.com/paritytech/cumulus/blob/release-parachains-v9430/pallets/collator-selection/src/lib.rs#L402

@bkchr bkchr closed this as completed Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants