Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server ignores subscription parameters #116

Closed
tomaka opened this issue Jul 1, 2020 · 0 comments · Fixed by #336
Closed

Server ignores subscription parameters #116

tomaka opened this issue Jul 1, 2020 · 0 comments · Fixed by #336

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 1, 2020 •
edited
Loading

This is a big "oops" moment. Being able to pass parameters when subscribing is a pretty important aspect but that I completely forgot about.

At the moment the API of Server only exposes RegisteredSubscription::send in order to send a notification to all the clients that have subscribed, while in the clients can subscribe and unsubscribe without any consideration for the parameters that they passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ws server]: support for subscriptions with params paritytech/jsonrpsee
1 participant
@tomaka