implement simple error propagation for subscriptions #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @dt665m signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
|
Sorry for not responding to that. There are caveats deeper in the client regarding error propagation that need to be fixed as well, and I'll need to come back to this and look in the details. |
|
@tomaka no worries, this isn't a complete implementation of error handling as the I didn't have much time to look deeper into the RawClient. For my use case, I just needed a way to be notified if an error occurred the temporary solution was to close the channel. |
dt665m
force-pushed
the
feature/client-error-handling
branch
3 times, most recently
from
098bfa2 to
f4408c2
Compare
dt665m
force-pushed
the
feature/client-error-handling
branch
from
2bc5566 to
50b610b
Compare
|
Fixed by #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagating errors is currently not implemented. This PR tries to enable Client Subscriptions to signal downstream that a channel has been closed due to errors in the inner RawClient.
Ready::(None)when the mpsc sender is dropped.The stream trait was implemented such that current libs depending on the Subscription.next() API, such as substrate-subxt, wont break. Users can choose to poll the Subscription as a wrapped stream to get notified of the closed internal mpsc receiver or use subscription.next() future, which will loop with "pending" forever on error.