Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify error types in the servers. #294

Merged
merged 1 commit into from
Apr 28, 2021
Merged

unify error types in the servers. #294

merged 1 commit into from
Apr 28, 2021

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Apr 27, 2021 •
edited
Loading

It was really annoying to deal with when trying to integrate in substrate.

Maybe we should try to split up the error in with different types instead to reduce the scope instead of depending on the big Error enum

@niklasad1 niklasad1 requested review from maciejhirsz and dvdplm April 27, 2021 17:18
dvdplm
dvdplm approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I ran into a similar frustration the other day. This seems like a good first step.

@niklasad1 niklasad1 merged commit d18fca3 into master Apr 28, 2021
@niklasad1 niklasad1 deleted the na-unify-rpcerror-and-error branch April 28, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@maciejhirsz maciejhirsz Awaiting requested review from maciejhirsz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niklasad1 @dvdplm