[servers] extract rpc modules to utils #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extracts the `rpc_module` from the servers to be shared. It will help to re-use rpc modules within both the servers
niklasad1
force-pushed
the
na-extract-server-module
branch
from
d8c4bec to
286edbe
Compare
dvdplm
reviewed
May 17, 2021
utils/src/server/mod.rs
Outdated
| /// Abstract JSON-RPC modules that can be used to register methods on a server. | ||
| pub mod rpc_module; | ||
|
|
||
| /// Sender. |
There was a problem hiding this comment.
There's a lot of sending going on in this library… can you extend the docs a bit here please?
There was a problem hiding this comment.
renamed it to MethodSink and added some docs, should be more understandable now.
Can you take another look?
Seems like a minor annoyance. Let's log a low-prio issue and move on. |
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
dvdplm
approved these changes
May 18, 2021
Co-authored-by: David <[email protected]>
…rpsee into na-extract-server-module
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #307
One annoyance with this, is that it's possible to register subscription on HTTP server with this.
Maybe introduce some trait for circumvent this?!