Switch from anyhow::Result to std Result #333
Conversation
| tokio::spawn(async move { server.start().await }); | ||
| addr | ||
| Ok(addr) |
| @@ -18,3 +18,7 @@ log = { version = "0.4", default-features = false } | |||
| serde = { version = "1", default-features = false, features = ["derive"] } | |||
| serde_json = { version = "1", default-features = false, features = ["alloc", "raw_value", "std"] } | |||
| thiserror = "1.0" | |||
| # TODO: a bit sad to have to pull in soketto to handle errors | |||
| soketto = "0.4" | |||
There was a problem hiding this comment.
yeah, I don't know how handle those without removing the shared error type.
but maybe a good idea to kill the big error type and that each crates has to define their own error type in another PR?
There was a problem hiding this comment.
Won't that make it tricky to share code between the servers?
There was a problem hiding this comment.
Yeah, unless you come up with super nice generic error type that both can use but then you need some extra boiler-plate.
Like map.err(|e| Error::Transport(Box::new(e))
There was a problem hiding this comment.
I can't think of a better way other than adding features, which I'm not sure is such a good idea.
There was a problem hiding this comment.
ok, you mean making soketto and hyper optional dependencies?
That's ok but why not let each crate implement implement the From<TransportError> for Error?
Then we shouldn't bring in any extra dependencies but a little bit of "redundant code", like for client/server as long they use the same transport library
There was a problem hiding this comment.
hat's ok but why not let each crate implement implement the
From<TransportError> for Error?
Then we shouldn't bring in any extra dependencies but a little bit of "redundant code", like for client/server as long they use the same transport library
| @@ -130,7 +130,8 @@ impl RpcModule { | |||
| self.methods.insert( | |||
| unsubscribe_method_name, | |||
| Box::new(move |id, params, tx, conn| { | |||
| let sub_id = params.one().map_err(|e| anyhow::anyhow!("{:?}", e))?; | |||
| // let sub_id = params.one().map_err(|e| anyhow::anyhow!("{:?}", e))?; | |||
There was a problem hiding this comment.
| // let sub_id = params.one().map_err(|e| anyhow::anyhow!("{:?}", e))?; |
There was a problem hiding this comment.
My bad. Fixed this one in #334
Don't return
anyhow::Resultand instead just usethiserrorand standardResult<T, Error>whereErroris thejsonrpsee_types::error::Errortype.The downside is that with this PR
jsonrpsee_typesdepends on bothsokettoandhyper. I think makingjsonrpsee_typesas dependency-free as possible was a big part of an external crate in the first place. OTOH all users will depend on at least one of them.