Proc macro params optimizations and tests. #421
Conversation
| } | ||
| } | ||
|
|
||
| pub fn traverse_type(ty: &mut Type, replaced: &mut bool, f: fn(&mut Type, &mut bool)) { |
There was a problem hiding this comment.
I like this separation; def makes the code cleaner!
| @@ -47,6 +48,16 @@ mod rpc_impl { | |||
|
|
|||
| #[subscription(name = "echo", unsub = "no_more_echo", item = u32)] | |||
| fn sub_with_params(&self, val: u32); | |||
|
|
|||
| #[method(name = "params")] | |||
| fn params(&self, a: u8, b: &str) -> String { | |||
There was a problem hiding this comment.
I reckon it'd be nice to have some more tests to exercise this lisetime stuff (if that makes sense); like, trying a couple of custom types with generics (elided or not) and a type with more than one lifetime to check that we hit a compile error (and preferably a nice one).
There was a problem hiding this comment.
Added a bunch of tests for that purpose :)
|
Looks awesome! If I understand right, a big change in this PR is actually adding support for lifetimes when using the RPC macro? A couple of questions came up (assuming that's true) around adding more tests to exercise this lifetime stuff, and throwing a friendly error when more than one lifetime is encountered. |
Fixes allocation in proc macro param parsing (#403). Closes #404.