Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust monitoring for new deployment setup #3004

Open
bkontur opened this issue May 30, 2024 · 2 comments
Open

Adjust monitoring for new deployment setup #3004

bkontur opened this issue May 30, 2024 · 2 comments
Assignees

Comments

@bkontur
Copy link
Contributor

bkontur commented May 30, 2024

  • complex relayer was replaced by headers-a, headers-b, parachains-a, parachains-b, messages-a, messages-b
  • adjust dashboards
  • add equivocation stuff to monitoring
  • check why data are empty:
    image
@bkontur bkontur self-assigned this May 30, 2024
@svyatonik
Copy link
Contributor

@bkontur Most of dashboards are working fine. E.g.:
image

This "No data" is maybe because the metric name has changed to e.g. at_BridgeHubKusama_relay_BridgeHubPolkadotMessages_balance. But probably we should remove it at all - there are no any alerts attached and now we have 3 different relayer accounts on each chain. Idk

@bkontur
Copy link
Contributor Author

bkontur commented Oct 9, 2024

  • fix Relay balances at metric:

I see now, why all the dashboards are empty for metric:
Relay balances at RococoBridgeHub
Relay balances at WestendBridgeHub
Relay balances at KusamaBridgeHub
Relay balances at PolkadotBridgeHub

Because we run add_relay_balances_metrics only for complex relay here.

We don't run those metrics for standalone relaying: relayer-headers or relay-parachains or relay-messages.

It would be nice to add those metrics for all relayings as on-demand, so the relayer can say with cli argument to add or not those metrics.

Till the time we fix this (or remove those alerts/dashboards), I am pausing those alerts:
image

github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue Feb 19, 2025
Closes: #7272
Relates to: #6578
Relates to: #7274

## Description

The PR enhances the `pallet-bridge-rewards` by making it generic over
the `RewardKind` type (previously hardcoded as `RewardsAccountParams`).
This modification allows the pallet to support multiple reward types
(e.g., P/K bridge, Snowbridge), increasing its flexibility and
applicability across various bridge scenarios.

Other pallets can register rewards using `bp_relayers::RewardLedger`,
which is implemented by the rewards pallet. The runtime can then be
configured with different mechanisms for paying/claiming rewards via
`bp_relayers::PaymentProcedure` (e.g., see the `pub struct
BridgeRewardPayer;` implementation for BridgeHubWestend).

## Follow-up  
The removed balances/rewards statistics from the complex relay (no
longer used) will eventually be reintroduced or fixed in the standalone
relayers via
paritytech/parity-bridges-common#3004 (comment).

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Serban Iorga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants