Vstaging statement distribution omnibus #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slumber
reviewed
Sep 7, 2023
polkadot/node/network/statement-distribution/src/vstaging/mod.rs
Outdated
Show resolved
Hide resolved
rphmeier
force-pushed
the
rh-debug-statement-dist
branch
from
9d50f8e to
c63cb21
Compare
Closes #1478 For this issue we wanted to add tests to cover three cases: 1. A cluster member seeing a Seconded message should request the candidate from the sender 2. A cluster member receiving a request should respond if the requester has not sent them any statements about the candidate 3. A cluster member should reject requests if the requester appears to know the candidate (has sent them a Seconded statement) Case 1 is already covered by the test `seconded_statement_leads_to_request` in `polkadot/node/network/statement-distribution/src/vstaging/tests/cluster.rs` Cases 2 and 3 are covered by the new test `local_node_checks_that_peer_can_request_before_responding` added in this PR
2 tasks
sandreim
reviewed
Oct 20, 2023
polkadot/node/network/collator-protocol/src/collator_side/mod.rs
Outdated
Show resolved
Hide resolved
polkadot/node/network/statement-distribution/src/v2/candidates.rs
Outdated
Show resolved
Hide resolved
| @@ -542,6 +556,13 @@ pub(crate) async fn handle_active_leaves_update<Context>( | |||
| ); | |||
| } | |||
|
|
|||
| gum::debug!( | |||
There was a problem hiding this comment.
Suggested change
| gum::debug!( | |
| gum::trace!( |
There was a problem hiding this comment.
just once per leaf update, not too spammy.
eskimor
approved these changes
Oct 20, 2023
sandreim
approved these changes
Oct 20, 2023
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* added parachains pallet benchmarks * deduplicate insertion of bridged header * pruning weight * fixes * fix compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in-progress PR adding new tests and solving bugs