-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically build and attach production and dev runtimes to GH releases #2054
Automatically build and attach production and dev runtimes to GH releases #2054
Conversation
@PierreBesson could you please confirm if the dev debug runtimes have logging enabled as you requested in the issue? Runtimes have been built on my fork https://github.com/liamaharon/polkadot-sdk/releases/tag/test-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments to improve a bit but LGTM, thanks !
Co-authored-by: Chevdor <[email protected]>
Co-authored-by: Chevdor <[email protected]>
…m:paritytech/polkadot-sdk into liam-build-and-attach-runtimes-to-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits but LGTM
Co-authored-by: Dónal Murray <[email protected]>
…m:paritytech/polkadot-sdk into liam-build-and-attach-runtimes-to-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
LGTM |
…ases (#2054) Closes paritytech/release-engineering#6 Adds a new Github Workflow which on a new release being created, builds and attaches all runtimes managed in this repository in two flavours: - `dev-debug-build`: Built with the `try-runtime` feature and has logging enabled - `on-chain-release`: Built with the regular old `on-chain-release` feature The new Github Workflow could be extended in the future by the @paritytech/release-engineering team to fully automate the release process if they choose to, similar to how it is fully automated in the Fellowship repo (https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/release.yml). The `on-chain-release` did not exist for parachains, so I added it. --- Tested on my fork: - https://github.com/liamaharon/polkadot-sdk/actions/runs/6663773523 - https://github.com/liamaharon/polkadot-sdk/releases/tag/test-6 --------- Co-authored-by: Chevdor <[email protected]> Co-authored-by: Dónal Murray <[email protected]>
Closes https://github.com/paritytech/release-engineering/issues/6
Adds a new Github Workflow which on a new release being created, builds and attaches all runtimes managed in this repository in two flavours:
dev-debug-build
: Built with thetry-runtime
feature and has logging enabledon-chain-release
: Built with the regular oldon-chain-release
featureThe new Github Workflow could be extended in the future by the @paritytech/release-engineering team to fully automate the release process if they choose to, similar to how it is fully automated in the Fellowship repo (https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/release.yml).
The
on-chain-release
did not exist for parachains, so I added it.Tested on my fork: