Enable cross-chain NFT transfers on asset-hub #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
approved these changes
Jan 5, 2024
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
…nfig.rs Co-authored-by: joe petrowski <[email protected]>
…onfig.rs Co-authored-by: joe petrowski <[email protected]>
bkontur
reviewed
Jan 5, 2024
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
|
Not sure why the prdoc CI check is failing. |
franciscoaguirre
approved these changes
Jan 12, 2024
Merged
via the queue into
paritytech:master
with commit Jan 19, 2024
50a2e28
122 of 124 checks passed
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
UniquesTransactorto asset-hub-rococoUniquesTransactorto asset-hub-westendWe can't add a transactor for
pallet-nftslike we do forpallet-uniquesbecausepallet-nftsusesnonfungibles_v2::Mutateinstead ofnonfungibles::Mutate, and making that work would be out of scope of this PR.With these modifications, reserve-based NFT cross-chain transfers can be performed on asset-hub.