Add subsystem benchmarks for availability-distribution and biftield-distribution (availability write)
#2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
…reim/subsystem-bench
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
sandreim
added
T0-node
…reim/availability-write-bench
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
alexggh
approved these changes
Jan 19, 2024
AndreiEres
approved these changes
Jan 22, 2024
alindima
reviewed
Jan 23, 2024
Comment on lines
+233
to
+240
| state.backed_candidates.push( | ||
| candidate_hashes | ||
| .get(&Hash::repeat_byte(block_num as u8)) | ||
| .expect("just inserted above") | ||
| .get(0) | ||
| .expect("just inserted above") | ||
| .clone(), | ||
| ); |
There was a problem hiding this comment.
I think we could just store the candidate hash in the backed_candidates map.
There was a problem hiding this comment.
I am not sure I understand correctly, but backed_candidates is a vec ( per relay block candidates backed by the node under test) and it stores CandidateReceipt
There was a problem hiding this comment.
right, in my mind vec is also a map from an integer to smth :D
i am suggesting based on my reading of the code, that we could only store the CandidateHash in the backed_candidates instead of the full receipt and then use the candidate index to fetch the receipt from the candidate_receipt_templates, if that makes sense.
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
alindima
approved these changes
Jan 23, 2024
…reim/availability-write-bench Signed-off-by: Andrei Sandu <[email protected]>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
#2970 accidentally added a crate twice to the workspace. Now extending the workspace check to explicitly error then. I think the check should also be required now. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/what-are-subsystem-benchmarks/8212/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new test objective :
DataAvailabilityWrite.The new benchmark measures the network and cpu usage of
availability-distribution,biftield-distributionandavailability-storesubsystems from the perspective of a validator node during the process when candidates are made available.Additionally I refactored the networking emulation to support bandwidth acounting and limits of incoming and outgoing requests.
Screenshot of succesful run