Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[xcm-v3] trait DispatchBlob return value issue #6629

Closed
bkontur opened this issue Jan 25, 2023 · 2 comments
Closed

[xcm-v3] trait DispatchBlob return value issue #6629

bkontur opened this issue Jan 25, 2023 · 2 comments

Comments

@bkontur
Copy link
Contributor

bkontur commented Jan 25, 2023

originally reported here: #4097 (comment)
(but probably lost in lots of comments in xcm-v3 big PR)

Isssue:
misleading doc and returns the unexpectable weight consumed by the dispatch vs Result<() ?

        /// Dispatches an incoming blob and returns the unexpectable weight consumed by the dispatch.
	fn dispatch_blob(blob: Vec<u8>) -> Result<(), DispatchBlobError>;

https://github.com/paritytech/polkadot/blob/master/xcm/xcm-builder/src/universal_exports.rs#L235-L237

Proposed solution:

  1. fix doc - just remove and returns the unexpectable weight consumed by the dispatch
  2. fix return value, like:
    fn dispatch_blob(blob: Vec<u8>) -> Result<Weight, DispatchBlobError>
    or
    fn dispatch_blob(blob: Vec<u8>) -> Result<Option<Weight>, DispatchBlobError> 
    
  3. other?
@bkontur
Copy link
Contributor Author

bkontur commented Jan 25, 2023

@gavofyork @KiChjang if you have sometime, could you, please, look at this? I could fix it, if you give me some hints :)

@bkontur
Copy link
Contributor Author

bkontur commented May 15, 2023

fixed docs by #7230

@bkontur bkontur closed this as completed May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant