Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

registrar: Avoid freebies in provide_judgement #12460

Closed
gavofyork opened this issue Oct 10, 2022 · 3 comments · Fixed by #12465
Closed

registrar: Avoid freebies in provide_judgement #12460

gavofyork opened this issue Oct 10, 2022 · 3 comments · Fixed by #12465
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@gavofyork
Copy link
Member

In provide_judgement, evaluate the return value of repatriate_reserved and do not store the judgement if it fails. The registrar will still have to pay the fees without getting any compensation but at least the user won't get a confirmed identity for free.
@gavofyork gavofyork added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Oct 10, 2022
@gavofyork gavofyork moved this to Backlog in Runtime / FRAME Oct 10, 2022
@bkchr bkchr added the Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder label Oct 10, 2022
@dharjeezy
Copy link
Contributor

I want to pick this up. @gavofyork @bkchr
Meanwhile, should any specific error be thrown if the result coming from repatriate_reserved is an error?

@bkchr
Copy link
Member

bkchr commented Oct 10, 2022

You probably want to introduce a new error variant, but nothing fancy.

@dharjeezy dharjeezy mentioned this issue Oct 10, 2022
Merged
@dharjeezy
Copy link
Contributor

You probably want to introduce a new error variant, but nothing fancy.

Alright. done

@dharjeezy dharjeezy mentioned this issue Oct 17, 2022
Merged
Repository owner moved this from Backlog to Done in Runtime / FRAME Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

registrar: Avoid freebies in provide_judgement dharjeezy/substrate
3 participants
@gavofyork @bkchr @dharjeezy