Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

client/beefy: BEEFY equivocation processing #12692

Closed
Tracked by #2462
acatangiu opened this issue Nov 11, 2022 · 1 comment · Fixed by #13121
Closed
Tracked by #2462

client/beefy: BEEFY equivocation processing #12692

acatangiu opened this issue Nov 11, 2022 · 1 comment · Fixed by #13121
Labels
J0-enhancement An additional feature request. U2-some_time_soon Issue is worth doing soon. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase.

Comments

@acatangiu
Copy link
Contributor

BEEFY must deal with equivocations. That includes at least:

  • detect equivocations
  • report equivocations
  • initiate slashing

Also, since BEEFY is based on GRANDPA, there is an edge case that Alistair mentioned:

We can have BEEFY validators slashable for voting for something on a different fork when this one was finalised. This is not quite an equivocation, and we should cancel the slash if they can point out a valid GRANDPA justification for the fork they voted for.
@acatangiu acatangiu added J0-enhancement An additional feature request. U2-some_time_soon Issue is worth doing soon. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase. labels Nov 11, 2022
@acatangiu acatangiu added this to BEEFY Nov 11, 2022
@acatangiu acatangiu moved this to Need for Polkadot 🗒 in BEEFY Nov 11, 2022
@acatangiu acatangiu moved this from Need for Polkadot 🗒 to Need for Kusama 🗒 in BEEFY Nov 11, 2022
This was referenced Nov 11, 2022
Closed
Closed
@acatangiu
Copy link
Contributor Author

Make sure to also track and punish votes spamming that could saturate buffers and impede progress. See this for more details.

@acatangiu acatangiu mentioned this issue Dec 5, 2022
Merged
@acatangiu acatangiu mentioned this issue Jan 10, 2023
Merged
@github-project-automation github-project-automation bot moved this from Need for Kusama 🗒 to Done ✅ in BEEFY Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request. U2-some_time_soon Issue is worth doing soon. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase.
Projects
No open projects
BEEFY
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BEEFY: implement equivocations detection, reporting and slashing acatangiu/substrate
1 participant
@acatangiu