Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[COREDEV] introduce a PR test-process #13470

Closed
ghost opened this issue Feb 25, 2023 · 3 comments
Closed

[COREDEV] introduce a PR test-process #13470

ghost opened this issue Feb 25, 2023 · 3 comments
Labels
I5-tests Tests need fixing, improving or augmenting.

Comments

@ghost
Copy link

ghost commented Feb 25, 2023

          Next time we should ad some zombienet test for syncing to ensure we don't break it again :D

Originally posted by @bkchr in #13409 (review)

Process should be mandatory

(example)

core developers

Mandatory "zombienet" Test

  • if your change affects xyz
    • use zombienet-n for testing (pre Merge)
      • via cli 'docker ...'

Mandatory Regression Test

  • if you revert a merge (commit, PR), either
    • provide a new automated regression test that catches the error
      • or (in the case an automation is not possible or high effort)
        • provide a manual regression test step in the Core Developer Manual
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Feb 25, 2023
@ghost ghost changed the title [COREDEV] consider introduce a PR test-process [COREDEV] introduce a PR test-process Feb 25, 2023
@ggwpez ggwpez added I5-tests Tests need fixing, improving or augmenting. and removed J2-unconfirmed Issue might be valid, but it’s not yet known. labels Feb 25, 2023
@bkchr
Copy link
Member

bkchr commented Feb 27, 2023

We have a test process and always extending our tests. You will not find that much prs that go in without any new tests.

@bkchr bkchr closed this as completed Feb 27, 2023
@bkchr
Copy link
Member

bkchr commented Feb 27, 2023

but mostly about a process that ensures that test-processes are always extended when an new incident occurs.

As I said, this is already things we are doing. We have added dozens of tests to ensure that incidents are not gonna happen again.

@bkchr
Copy link
Member

bkchr commented Feb 27, 2023

Then please inform me, what is the essence? Maybe I'm missing it. Sorry

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I5-tests Tests need fixing, improving or augmenting.
Projects
None yet
Development

No branches or pull requests

2 participants