Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Destroy all RocksDB objects before static destructors run #7166

Closed
DemiMarie opened this issue Sep 21, 2020 · 4 comments
Closed

Destroy all RocksDB objects before static destructors run #7166

DemiMarie opened this issue Sep 21, 2020 · 4 comments
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@DemiMarie
Copy link

Otherwise we will run into undefined behavior in RocksDB: facebook/rocksdb#649
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Sep 21, 2020
@bkchr
Copy link
Member

bkchr commented Sep 22, 2020

Why is that a Substrate issue?

@DemiMarie
Copy link
Author

It shows up as a crash on shutdown in certain scenarios, and I don’t think Facebook is interested in fixing the behavior of RocksDB.

@bkchr
Copy link
Member

bkchr commented Sep 23, 2020

If you don't provide scenarios in which this happens, we can not fix this.

@DemiMarie
Copy link
Author

It happens when running unit tests for current substrate-subxt git HEAD, although not reliably.

@DemiMarie DemiMarie mentioned this issue Apr 14, 2021
Closed
@bkchr bkchr closed this as completed Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkchr @DemiMarie