This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Network sync refactoring (part 5) #11825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g factory method
nazar-pc
force-pushed
the
network-sync-refactoring-part-5
branch
from
3bacc37 to
18cde57
Compare
|
@arkpar you were reviewing previous PR, maybe you can take a look? |
|
I'd suggest removing |
bkchr
approved these changes
Jul 29, 2022
arkpar
approved these changes
Jul 29, 2022
bkchr
added
A0-please_review
|
bot merge |
|
Waiting for commit status. |
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Make `chain_sync` an explicit networking parameter instead of offering factory method * Derive `Copy` on `SyncMode` and remove cloning
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Make `chain_sync` an explicit networking parameter instead of offering factory method * Derive `Copy` on `SyncMode` and remove cloning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards #8686
This addresses ugliness in configuration with factory method after #11412 as discussed in #11412 (comment)
Not entirely happy with sync mode matching in multiple places, open for suggestions.