fix: don't wrap rpc error in DisconnectedWillReconnect in reconnecting rpc client #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
Jan 24, 2025
pkhry
approved these changes
Jan 24, 2025
jsdw
approved these changes
Jan 24, 2025
|
Also do this for subscription errors which at present are also wrapped all in DisconnectedWillReconnect? (https://github.com/paritytech/subxt/pull/1904/files#diff-da5ee6aaf17c0bda395d17b3925f6787c336406bb9ec5a82d1e031919219836eL452) |
|
LGTM, good job debugging and fixing @niklasad1! |
niklasad1
added a commit
that referenced
this pull request
Jan 24, 2025
…g rpc client (#1904) * fix: don't wrap rpc err in DisconnectedWillRecon * add clarifying comment * fix no-std-test build * fix no-std-test build v2
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Jan 24, 2025
- Add option to specify database_url using DATABASE_URL environment variable - Add a eth-rpc-tester rust bin that can be used to test deployment before releasing eth-rpc - make evm_block non fallible so that it can return an Ok response for older blocks when the runtime API is not available - update cargo.lock to integrate changes from paritytech/subxt#1904 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1903
This mistake made all rpc error to be treated as
DisconnectingWillReconnectand that would hang forever becausewe don't have a limit on those in the retry function.
Thus, important that
DisconnectingWillReconnectis actually only emitted when a connection lost.Tested in https://github.com/niklasad1/reproduce-subxt-retry-issue