-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credits page #24
credits page #24
Conversation
- dev_dependencies variables - send all package info for further usage - use local jinja template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Just a few quality things to fix (see CI)
i think i misunderstand jinja and copier. |
So, credits must be generated each time we build the docs (because dependencies can change regularly). You tried to use a shortcut: that's a nice idea. But in your changes macros is injecting Or you could refactor to use the same logic as in the copier-pdm template, i.e. stop using macros and replace it with mkdocs-gen-files. |
i think i will choose this one |
Co-authored-by: Timothée Mazzucotelli <[email protected]>
resolves #22