Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should return only placetypes supported by old pip-service #74

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

Joxit
Copy link
Member

@Joxit Joxit commented Jan 20, 2021

Hi there 😄

I'm planning to use spatial in production, so I'm doing some full import and tests.

I found something during my full import, this error message :

error: [dbclient-geonames] [400] type=strict_dynamic_mapping_exception, reason=mapping set to strict, dynamic introduction of [macrohood] within [parent] is not allowed

The schema has a strict mapping and macrohood is not a part of it (see document.js).

My first idea is to restrict the output of the backward-compatible endpoint to the list of known placetypes from wof-admin-lookup

Copy link
Member

@missinglink missinglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with merging this as-is since it's meant to be compatible with the prior pip-service implementation.

Over time I'd like to remove any code which contains Pelias config or any policy decisions out of here as much as possible so its generic at build time and configurable at runtime.

@missinglink missinglink merged commit 782676b into master Jan 20, 2021
@Joxit Joxit deleted the joxit/fix/pip_pelias branch January 20, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants