Remove parameters from CustomMetadata struct
#376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@ebma where was the |
|
We actually have not used it yet. When starting with Spacewalk we just adopted it from interlay together with the |
|
As mentioned in the associated issue, I propose that we remove all entries from |
b-yap
reviewed
Jul 24, 2023
TorstenStueber
approved these changes
Jul 24, 2023
|
I'm merging this although the CI job is failing because the issue is related to #382 and not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
CustomMetadatastruct to something we can use with our pendulum runtimes. Thefee_per_secondparameter seems to be used for XCM calls, so it makes sense to keep it.For the review, please consider this comment.
Closes #375.