From 463bcac4e9d944f540758ed2047b968dc1b90913 Mon Sep 17 00:00:00 2001 From: Peter Bengtsson Date: Mon, 15 Apr 2019 09:10:20 -0400 Subject: [PATCH 1/2] commit.author can be null Fixes #86 --- src/DeployPage.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/DeployPage.js b/src/DeployPage.js index 6789c15..7955da4 100644 --- a/src/DeployPage.js +++ b/src/DeployPage.js @@ -288,7 +288,11 @@ class DeployTable extends React.Component { } } - if (commit.author.login === BORS_LOGIN && commit.author.type === 'Bot') { + if ( + commit.author && + commit.author.login === BORS_LOGIN && + commit.author.type === 'Bot' + ) { hasBors = true; } else if (borsMode) { continue; From d530ce65cab87f7dd68292396424f2c14af517d9 Mon Sep 17 00:00:00 2001 From: Peter Bengtsson Date: Mon, 15 Apr 2019 10:02:05 -0400 Subject: [PATCH 2/2] correct key --- src/DeployPage.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/DeployPage.js b/src/DeployPage.js index 7955da4..dfc5099 100644 --- a/src/DeployPage.js +++ b/src/DeployPage.js @@ -434,7 +434,10 @@ class CommitDetails extends React.Component { render() { let { commit, author, tag, html_url, borsMode, owner, repo } = this.props; - let involvedUsers = [author]; + let involvedUsers = []; + if (author) { + involvedUsers.push(author); + } let title; if (borsMode && author.login === BORS_LOGIN && author.type === 'Bot') { @@ -660,7 +663,7 @@ class Culprits extends React.PureComponent { On {group.name} {group.users.map(([role, user]) => ( -
+