Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] hilight text sections with different colors #2130

Open
abose opened this issue Feb 14, 2025 · 3 comments
Open

[feat] hilight text sections with different colors #2130

abose opened this issue Feb 14, 2025 · 3 comments
Labels
customer raised issues raised by end user/customer Feature Request Feature requests from customers

Comments

@abose
Copy link
Member

abose commented Feb 14, 2025

Describe the problem

Users should be able to select some part of text and mark it with a highlight color.
This should be persisted for the file across reboots.

https://www.reddit.com/r/brackets/comments/1ip0e88/interface_text_colour/

Describe the solution you'd like

Maybe have a marker icon in the statusbar and editor context menu?
This should be persisted for the file across reboots.

Alternatives considered

No response

Additional context

No response

@abose abose added customer raised issues raised by end user/customer Feature Request Feature requests from customers labels Feb 14, 2025
@abose abose moved this to Todo in New/Modern UX Feb 14, 2025
@abose abose added the good first issue Good for newcomers label Feb 14, 2025
@abhishek-kumar-91
Copy link

I want to work on this, Can you assign me?

@devvaannsh
Copy link
Contributor

devvaannsh commented Feb 15, 2025

Hii @abhishek-kumar-91, do you have any UX approach in mind?

Try working on it. Let us know if you run into any troubles.

@abose abose removed the good first issue Good for newcomers label Feb 16, 2025
@abose
Copy link
Member Author

abose commented Feb 16, 2025

Thank you @abhishek-kumar-91 for your interest in this feature.

I've reassessed the complexity of this issue and removed the good first issue tag, as it requires more extensive work than I initially though. We also need to properly define the UX flow and how it integrates with the existing UI.

A few points regarding contribution:

  1. We generally don't assign issues directly unless they're business-critical. Just comment your intention to work on it in the issue thread, ad that should help us track it.
  2. For new features, we recommend starting with an extension first. Please check our extension documentation at https://docs.phcode.dev/api/getting-started
  3. Once you have a working prototype as an extension, we can help with merging it into the core.

If you're specifically interested in implementing this feature despite its complexity(This is a very good feature to have), please let us know in the comments. However, if you're looking to contribute to Phoenix Code in general, we'd be happy to suggest some smaller, more beginner-friendly issues to help you get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer raised issues raised by end user/customer Feature Request Feature requests from customers
Projects
Status: Todo
Development

No branches or pull requests

3 participants