fix: reserved keyboard shortcuts in mac used for nav back and forward #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assigned reserved mac keyboard shortcut for word selection nav to code folding. release that shortcut to be unused in all platforms. Expand and collapse current rewired to `ctrl/cmd-shift-[` and `ctrl/cmd-shift-]` in all platforms as that shortcut was released from redundant recent navigation flows. Also, it aligns with `ctrl-[`and `ctrl-]` for indent changing. Expand and collpase all shortcut was never used in usage stats, so removed it.
We earlier used to associate this with navigate back and forward, now changing navigation shortcut in mac to Cmd-alt-Left and right which is unused and stantard mac browser fwd and back nav shortcut
…r navigation and not assignable So added framework option nativeOnly and browserOnly to selectiveley apply shortcut. in browser, mac, nav back and forward will be assigned to `Ctrl-Alt-Right` and left instead.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/orgs/phcode-dev/discussions/2019