-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builtin: add json quote #7832
builtin: add json quote #7832
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
@overbool Thanks! |
/ok-to-test |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@overbool any update? |
Sorry for my delay, I will update it in a few day. |
@overbool friendly ping 😄 Any update? |
8feb23d
to
f4d164d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #7832 +/- ##
==========================================
+ Coverage 67.24% 67.25% +<.01%
==========================================
Files 371 371
Lines 77203 77223 +20
==========================================
+ Hits 51916 51937 +21
- Misses 20645 20647 +2
+ Partials 4642 4639 -3
Continue to review full report at Codecov.
|
What problem does this PR solve?
a part of #7546
What is changed and how it works?
add a built in function json_quote
Check List
Tests
Code changes
Related changes
This change is