services: fix some TTS websocket service interruption handling #1272
+121
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
aconchillo
force-pushed
the
aleix/tts-websocket-interruptions
branch
3 times, most recently
from
e26c413 to
38019f5
Compare
aconchillo
force-pushed
the
aleix/tts-websocket-interruptions
branch
from
38019f5 to
94ee664
Compare
markbackman
reviewed
Feb 23, 2025
| @@ -434,6 +436,12 @@ async def _stop_frame_handler(self): | |||
|
|
|||
|
|
|||
| class WordTTSService(TTSService): | |||
| """This a base class for TTS services that support word timestamps. Word | |||
There was a problem hiding this comment.
Suggested change
| """This a base class for TTS services that support word timestamps. Word | |
| """This is a base class for TTS services that support word timestamps. Word |
markbackman
reviewed
Feb 23, 2025
| this to work, the TTS service needs to support handling multiple requests at | ||
| once (i.e. multiple simultaneous contexts). | ||
| class WebsocketTTSService(TTSService, WebsocketService): | ||
| """This a base class for websocket-based TTS services.""" |
There was a problem hiding this comment.
Suggested change
| """This a base class for websocket-based TTS services.""" | |
| """This is a base class for websocket-based TTS services.""" |
There was a problem hiding this comment.
Same typo in other docstrings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
@markbackman We already talked about this before. People are really hitting this issue, so even if not nice we need to support all TTS services as good as we can.
I did an optimization though. If the bot is not speaking and the user talks, we don't reconnect. We only reconnect if it's a real interruption.
Fixes #1258