Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Store resource to ClusterStore #434

Closed
wants to merge 2 commits into from
Closed

Conversation

tylerphelan
Copy link
Contributor

  • Kept StoreReader, StoreBuildpack, and StoreImage types
  • Some import changes

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #434 into master will increase coverage by 0.07%.
The diff coverage is 68.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   67.33%   67.40%   +0.07%     
==========================================
  Files          85       85              
  Lines        3612     3620       +8     
==========================================
+ Hits         2432     2440       +8     
  Misses        894      894              
  Partials      286      286              
Impacted Files Coverage Δ
pkg/apis/build/v1alpha1/builder_types.go 0.00% <ø> (ø)
pkg/apis/build/v1alpha1/cluster_builder.go 0.00% <ø> (ø)
.../apis/experimental/v1alpha1/cluster_store_types.go 0.00% <0.00%> (ø)
...apis/experimental/v1alpha1/custom_builder_types.go 0.00% <ø> (ø)
pkg/apis/experimental/v1alpha1/register.go 0.00% <0.00%> (ø)
pkg/cnb/buildpack_validation.go 100.00% <ø> (ø)
pkg/reconciler/sourceresolver/enqueuer.go 100.00% <ø> (ø)
pkg/secret/fetcher.go 0.00% <0.00%> (ø)
pkg/reconciler/custombuilder/custombuilder.go 46.15% <60.00%> (ø)
...ciler/customclusterbuilder/customclusterbuilder.go 46.15% <60.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337b4da...b15c766. Read the comment docs.

- Kept StoreReader, StoreBuildpack, and StoreImage types
- Some import changes
- Allows us to decouple store kind from builder
@tylerphelan
Copy link
Contributor Author

execute_build_test.go fixed in #437

@tylerphelan
Copy link
Contributor Author

closing this in favor of #437 where both renames will occur

@chenbh chenbh deleted the cluster-store branch July 25, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants