Feature/world boss fe #6881
Open
Feature/world boss fe #6881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-doobu
requested review from
sonohoshi and
jonny-jeahyunchoi
as code owners
Open
jonny-jeahyunchoi
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
nekoyumeproject, focusing on the removal of the World Boss feature and related assets, as well as updates to the localization files. The most important changes are grouped by theme below:Removal of World Boss Feature:
nekoyume/Assets/_Scripts/ApiClient/ApiClients.cs: RenamedWorldBossClienttoDataProviderClientand removed the initialization ofWorldBossQuery. [1] [2]nekoyume/Assets/_Scripts/ApiClient/WorldBossQuery.cs: Removed the entireWorldBossQueryclass and its methods.nekoyume/Assets/_Scripts/ApiClient/WorldBossQuery.cs.meta: Deleted the metadata file forWorldBossQuery.cs.nekoyume/Assets/AddressableAssets/UI/Module/Lobby/WorldBossBtn.prefab.meta: Deleted the metadata file for the World Boss button prefab.nekoyume/Assets/UIResources/Content/WorldBoss/Prefab/RankingNotShowingContainer.prefab.meta: Deleted the metadata file for the Ranking Not Showing Container prefab.Updates to Localization Files:
nekoyume/Assets/StreamingAssets/Localization/common.csv: Added new localization entries for "My Info" and other UI elements. [1] [2]nekoyume/Assets/StreamingAssets/Localization/notification.csv: Added new localization entries for World Boss reward notifications.Prefab Modifications:
nekoyume/Assets/Resources/AddressableAssetsContainer.asset: Added a new entry for a file withguid: 4c58b27b966ed5349adca40e6148722f.nekoyume/Assets/Resources/UI/Prefabs/UI_AdventureBossRewardInfoPopup.prefab: Removed a component and adjusted properties such asm_Valueandm_AnchoredPosition. [1] [2] [3] [4]These changes collectively remove the World Boss feature, clean up related assets, and update localization files to support new UI elements.