Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auto select grind20 #6872

Merged
merged 8 commits into from
Feb 17, 2025
Merged

Conversation

eugene-doobu
Copy link
Member

This pull request includes several modifications to the GrindModule.prefab and GrindModule.cs files in the nekoyume project. The primary changes involve adjustments to the UI elements and the addition of a new button, as well as refactoring the Awake method to improve code organization.

UI Changes:

  • Updated the m_RootOrder values for various RectTransform components to adjust the rendering order. [1] [2] [3] [4]
  • Added a new autoSelectButton to the MonoBehaviour component.
  • Modified the PrefabInstance properties to adjust the size, position, and other attributes of UI elements. [1] [2] [3] [4] [5]

Code Changes:

  • Added a new using directive for Nekoyume.Battle in GrindModule.cs.
  • Introduced a new autoSelectButton field in the CrystalAnimationData struct.
  • Refactored the Awake method to extract button event bindings into a separate method BindButtonEvents.
  • Added a missing return statement in the OnClickItem method to prevent further execution.
  • Updated the OnUpdateInventory method to use a cached list for inventory models.

@eugene-doobu eugene-doobu linked an issue Feb 17, 2025 that may be closed by this pull request
@github-actions github-actions bot added this to the v280.0.0 milestone Feb 17, 2025
@eugene-doobu eugene-doobu merged commit 41001e7 into development Feb 17, 2025
2 checks passed
@eugene-doobu eugene-doobu deleted the feature/auto-select-grind20 branch February 17, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Grinding 자동재료 등록 추가
1 participant